Skip to content

Commit

Permalink
Fix alt+scroll offset from elements above sticky header
Browse files Browse the repository at this point in the history
<rikaitan.link>YjdhNzNkMTc5NjRmN2Y0YWU1NmEzMTNmZjY0YWZhOTRlMjRlZmU2OAo=</rikaitan.link>
  • Loading branch information
Kuuuube committed Jun 25, 2024
1 parent 3421c98 commit f62a675
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 27 deletions.
6 changes: 3 additions & 3 deletions ext/js/display/display.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export class Display extends EventDispatcher {
/** @type {boolean} */
this._historyHasChanged = false;
/** @type {?Element} */
this._navigationHeader = document.querySelector('#navigation-header');
this._aboveStickyHeader = document.querySelector('#above-sticky-header');
/** @type {import('display').PageType} */
this._contentType = 'clear';
/** @type {string} */
Expand Down Expand Up @@ -1516,8 +1516,8 @@ export class Display extends EventDispatcher {
}
let target = (index === 0 && definitionIndex <= 0) || node === null ? 0 : this._getElementTop(node);

if (this._navigationHeader !== null) {
target -= this._navigationHeader.getBoundingClientRect().height;
if (this._aboveStickyHeader !== null && target !== 0) {
target += this._aboveStickyHeader.getBoundingClientRect().height;
}

this._windowScroll.stop();
Expand Down
50 changes: 26 additions & 24 deletions ext/search.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,31 +23,33 @@
<div class="content-outer">
<div class="content">
<div class="content-scroll scrollbar" id="content-scroll">
<div class="top-progress-bar-container"><div class="progress-bar-indeterminant" id="progress-indicator" hidden></div></div>
<div class="search-header-wrapper">
<div class="search-header">
<div id="intro">
<h1>Rikaitan Search</h1>
</div>
<div id="above-sticky-header">
<div class="top-progress-bar-container"><div class="progress-bar-indeterminant" id="progress-indicator" hidden></div></div>
<div class="search-header-wrapper">
<div class="search-header">
<div id="intro">
<h1>Rikaitan Search</h1>
</div>

<div class="scan-disable">
<div class="search-options">
<div class="search-option" id="search-option-profile-select">
<span class="profile-select-container"><select class="profile-select" id="profile-select">
<optgroup label="Primary Profile" id="profile-select-option-group"></optgroup>
</select></span>
</div>
<label class="search-option" id="search-option-clipboard-monitor-container">
<label class="toggle"><input type="checkbox" id="clipboard-monitor-enable"><span class="toggle-body"><span class="toggle-track"></span><span class="toggle-knob"></span></span></label>
<span class="search-option-label">Clipboard monitor</span>
</label>
<label class="search-option" id="search-option-wanakana">
<label class="toggle"><input type="checkbox" id="wanakana-enable"><span class="toggle-body"><span class="toggle-track"></span><span class="toggle-knob"></span></span></label>
<span class="search-option-label">Automatic kana conversion</span>
</label>
<div class="search-option" id="query-parser-mode-container" hidden>
<span class="search-option-pre-label">Parser:</span>
<select id="query-parser-mode-select"></select>
<div class="scan-disable">
<div class="search-options">
<div class="search-option" id="search-option-profile-select">
<span class="profile-select-container"><select class="profile-select" id="profile-select">
<optgroup label="Primary Profile" id="profile-select-option-group"></optgroup>
</select></span>
</div>
<label class="search-option" id="search-option-clipboard-monitor-container">
<label class="toggle"><input type="checkbox" id="clipboard-monitor-enable"><span class="toggle-body"><span class="toggle-track"></span><span class="toggle-knob"></span></span></label>
<span class="search-option-label">Clipboard monitor</span>
</label>
<label class="search-option" id="search-option-wanakana">
<label class="toggle"><input type="checkbox" id="wanakana-enable"><span class="toggle-body"><span class="toggle-track"></span><span class="toggle-knob"></span></span></label>
<span class="search-option-label">Automatic kana conversion</span>
</label>
<div class="search-option" id="query-parser-mode-container" hidden>
<span class="search-option-pre-label">Parser:</span>
<select id="query-parser-mode-select"></select>
</div>
</div>
</div>
</div>
Expand Down

0 comments on commit f62a675

Please sign in to comment.