Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Us From Engagement Bot Messages #1364

Merged
merged 5 commits into from
Jul 2, 2019
Merged

Conversation

wvauclain
Copy link
Contributor

@wvauclain wvauclain commented Jul 1, 2019

Issue Number

Fixes #1362

Purpose/Implementation Notes

I added a check for certain patterns in the code that notifies us with engagement-bot. I also added a check for the environment, which also required adding an environment variable in terraform.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)

Functional tests

List out the functional tests you've completed to verify your changes work locally.

Checklist

Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Screenshots

Please attach any screenshots that illustrate these changes.

Copy link
Contributor

@kurtwheeler kurtwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@wvauclain wvauclain merged commit da9300e into dev Jul 2, 2019
@wvauclain wvauclain deleted the wvauclain/engagement-bot branch July 2, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter out our emails from engagement bots
2 participants