Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration to update sample platform names #1412

Merged
merged 2 commits into from
Aug 2, 2019

Conversation

arielsvn
Copy link
Contributor

Issue Number

close #1249

Purpose/Implementation Notes

Adds a new migration to fix Sample platform names.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Functional tests

Tested locally.

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Screenshots

Logs

Updating platform name from 'IlluminaGenomeAnalyzerII' to 'Illumina Genome Analyzer II' page
Updating platform name from 'IlluminaGenomeAnalyzerIIx' to 'Illumina Genome Analyzer IIx' page
Updating platform name from 'IlluminaHiScanSQ' to 'Illumina HiScanSQ' page
Updating platform name from 'IlluminaHiSeq1000' to 'Illumina HiSeq 1000' page
Updating platform name from 'IlluminaHiSeq1500' to 'Illumina HiSeq 1500' page
Updating platform name from 'IlluminaHiSeq2000' to 'Illumina HiSeq 2000' page
Updating platform name from 'IlluminaHiSeq2500' to 'Illumina HiSeq 2500' page
Updating platform name from 'IlluminaHiSeq3000' to 'Illumina HiSeq 3000' page
Updating platform name from 'IlluminaHiSeq4000' to 'Illumina HiSeq 4000' page
Updating platform name from 'NextSeq500' to 'NextSeq 500' page
Updating platform name from 'NextSeq550' to 'NextSeq 550' page
Updating platform name from 'IonTorrentProton' to 'Ion Torrent Proton' page
Updating platform name from 'IonTorrentS5' to 'Ion Torrent S5' page
Updating platform name from 'IonTorrentS5XL' to 'Ion Torrent S5 XL' page

@arielsvn arielsvn requested a review from wvauclain July 23, 2019 19:04
@wvauclain
Copy link
Contributor

It looks fine to me, but I know that @kurtwheeler will want to look at any PRs involving migrations before we merge them

@wvauclain
Copy link
Contributor

Also, at the moment we have three pending PRs with different migration 0023s, so we will have to plan ahead before merging them

Copy link
Contributor

@kurtwheeler kurtwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks good to me, but I agree with @wvauclain about our migrations. We should be careful, deliberate, and coordinated when merging these in!

@arielsvn
Copy link
Contributor Author

arielsvn commented Aug 2, 2019

This also looks good to me, but I agree with @wvauclain about our migrations. We should be careful, deliberate, and coordinated when merging these in!

I agree, what do you think it's the best way to have these added? we could merge each PR separately and resolve conflicts in the others?

@kurtwheeler
Copy link
Contributor

Yep, that's more or less what I had in mind. The coordinated part is making sure that two of us aren't trying to do it at the same time.

@arielsvn
Copy link
Contributor Author

arielsvn commented Aug 2, 2019

ok I'm gonna go ahead and get this one merged

@arielsvn arielsvn merged commit 56f7a99 into dev Aug 2, 2019
@arielsvn arielsvn deleted the arielsvn/1249-platform-spaces-migration branch August 2, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same platforms showing up as different in metadata due to spacing inconsistencies
3 participants