Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an extra check to needs_downloading for transcriptome index jobs. #2165

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

kurtwheeler
Copy link
Contributor

Issue Number

Not sure, but this started breaking intermittently yesterday.

Purpose/Implementation Notes

Our transcriptome index jobs weren't handling a missing file quite correctly. This adds an additional check to needs_downloading to make sure they only recreate downloader jobs if they're the last processor job for the file.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Functional tests

The tests pass reliably!!!

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@kurtwheeler kurtwheeler merged commit e224c35 into dev Feb 26, 2020
@kurtwheeler kurtwheeler deleted the kurtwheeler/transcritome-redownloading-test branch February 26, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants