Fix metadata issues with quant sf files #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
kurtwheeler
reviewed
Jul 1, 2020
| @@ -1033,7 +1033,7 @@ def download_computed_file(download_tuple: Tuple[ComputedFile, str]): | |||
| logger.exception("Failed to sync computed file", computed_file_id=latest_computed_file.pk) | |||
|
|
|||
|
|
|||
| def sync_quant_files(output_path, samples: List[Sample]): | |||
| def sync_quant_files(output_path, samples: List[Sample], filtered_samples: Dict): | |||
There was a problem hiding this comment.
Could you note in the docstring that this function modifies filtered_samples to include samples that it's unable to sync?
kurtwheeler
approved these changes
Jul 1, 2020
wvauclain
force-pushed
the
wvauclain/quantpendia-metadata
branch
from
0bad3a7
to
67bc022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#2289
Purpose/Implementation Notes
Mark samples without quant.sf files as filtered so that they are not included in the metadata.
It looks like what was happening was that samples without quant.sf files were not being filtered out properly, so they would still be included in the metadata as samples in the compendia.
Types of changes
What types of changes does your code introduce?
Functional tests
I modified the quantpendia unit test, and checked that my fix made it pass.
Checklist
Put an
xin the boxes that apply.Screenshots
Please attach any screenshots that illustrate these changes.