-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Support initialize llumlet by manager #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuilongCui
reviewed
Aug 16, 2024
KuilongCui
reviewed
Aug 16, 2024
zhypku
reviewed
Aug 19, 2024
ZeldaHuang
approved these changes
Aug 20, 2024
KuilongCui
approved these changes
Aug 21, 2024
KuilongCui
approved these changes
Aug 21, 2024
s5u13b
changed the title
[BugFix] Support initialize llumlet in manager
[BugFix] Support initialize llumlet by manager
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the migration backend is gloo, during scale_up/scale_down, llumnix needs to re-initialize the migration communication process group. However, Ray requires that all the processes that attempt to initialize the process group share the same driver process to ensure that the job_id is consistent. This means that all the llumlets should be initialized in the same process in llumnix. Previously, llumnix initialize llumlet in the entrypoint process, and we can have multiple entrypoints in llumnix, so the driver process of llumlets can be different. Therefore, we support initializing llumlet by the manager as another option in llumnix to ensure that all the llumlets can share the same driver process(manager).