[Misc] Check manager and engine arguments in entrypoints #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeldaHuang
approved these changes
Aug 28, 2024
zhypku
approved these changes
Aug 29, 2024
KuilongCui
reviewed
Aug 29, 2024
KuilongCui
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Llumnix asserts unsupported arguments in the functions that use the arguments. This pr adds manager arguments checker function in arg_utils.py, and checks manager and engine arguments in entrypoints. With this pr, we can have a unified entrance checking all the manager/engine arguments instead of checking in several places, which is more user-friendly.
Also, I refine the exception output passingly in this pr.