[BugFix] Add stream synchronize for nccl migration backend #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s5u13b
changed the title
ZeldaHuang
reviewed
Aug 28, 2024
KuilongCui
force-pushed
the
worker_test
branch
from
0f60d1f
to
98eac4d
Compare
KuilongCui
changed the title
zhypku
approved these changes
Aug 29, 2024
ZeldaHuang
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after dst worker recv data from col.recv, it need to copy data to self.gpu_cache. Before copying, it must wait cuda stream in col.recv. As nccl migration backend use cupy cuda stream, in this pr change migration stream to cupy stream for synchronize.