Merged Noise Map branch

[nivram-phy]

To improve the masking of number of noisy pixel, we will now be obtaining a merged noise map where the current noise map is merged with non-unique objects of two maps in the recent past.

[github-actions]

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

[nivram-phy]

@mconcas @shahor02 Hello! How can I proceed with the Security approval that is needed for this?

[mconcas]

Approving to start testing

[alibuild]

Error while checking build/O2/fullCI for fc8a064 at 2024-08-27 05:08:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13356-slc8_x86-64/0/Detectors/ITSMFT/ITS/reconstruction/src/ClustererTask.cxx:36:16: error: use '= default' to define a trivial destructor [modernize-use-equals-default]
/sw/SOURCES/O2/13356-slc8_x86-64/0/Detectors/ITSMFT/MFT/simulation/src/DigitizerTask.cxx:36:16: error: use '= default' to define a trivial destructor [modernize-use-equals-default]
/sw/SOURCES/O2/13356-slc8_x86-64/0/Detectors/ITSMFT/ITS/workflow/src/ThresholdAggregatorSpec.cxx:27:25: error: use '= default' to define a trivial default constructor [modernize-use-equals-default]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

[nivram-phy]

@mconcas @shahor02 Sorry for pinging again, but this looks like the error is arising from some other aspects of the code that I made no modifications to. Is there something I can do from my end to move this forward? Thank you!

[shahor02]

The errors are indeed unrelated but please check the comments below.

[iravasen]

I will soon (1-2 days) make a review of this PR as well just to check there are no conflicts with what we do in ITS.

[iravasen]

Sorry for the delay. To me this does not seem to have an impact on ITS noise calib.
@nivram-phy can I ask you for curiosity why you need to merge the current noise map with a previous one existing in CCDB? I'm curious to know to see whether it could be useful for ITS as well.

[nivram-phy]

@iravasen So we noticed that just stochastically, we miss a few pixels in a noise scan sometime. These pixels were flagged as noisy in most other noise runs, but in a particular run, due to perhaps some issue with the data communication, this wasn’t flagged as problematic. Merging with two previous noise maps helps reduce this. In our new implementation, we will save both current map and the merged map and every merged map is only an intersection of current +two previous maps.

This increases the number of noisy pixels by about 6%, from about 7500 typically to 8000.

[iravasen]

@iravasen So we noticed that just stochastically, we miss a few pixels in a noise scan sometime. These pixels were flagged as noisy in most other noise runs, but in a particular run, due to perhaps some issue with the data communication, this wasn’t flagged as problematic. Merging with two previous noise maps helps reduce this. In our new implementation, we will save both current map and the merged map and every merged map is only an intersection of current +two previous maps.

This increases the number of noisy pixels by about 6%, from about 7500 typically to 8000.

I see thanks a lot!

[nivram-phy]

@shahor02 I think I have addressed all the points you have raised. Let me know if all looks good to be merged. Thank you

[shahor02]

Checks were passed, merging after insignificant change.