Fix wrong initialization order #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthiasrichter this is the warning I was referring to earlier on slack. |
There was a problem hiding this comment.
I don't understand this. What is the actual error/warning you get? I have been looking more than twice now in DataHeader.h, I think the initialization order is correct, the members of DataHeader are:
DataDescription dataDescription;
DataOrigin dataOrigin;
uint32_t reserved;
SerializationMethod payloadSerializationMethod;
|
Indeed, I do not understand it as well. Let's hold on this. |
|
I am closing this to prevent accidental merge. @ktf: It still somehow relevant please keep track in an issue. |
knopers8
pushed a commit
to knopers8/AliceO2
that referenced
this pull request
Sep 7, 2020
mbroz84
pushed a commit
to mbroz84/AliceO2
that referenced
this pull request
Mar 16, 2022
Minor modifications and error fixes Minor modifications Minor modifications Minor modifications Minor changes Minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.