Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITS tracking works on generic N layers #4511

Merged
merged 20 commits into from
Nov 27, 2020
Merged

Conversation

mpuccio
Copy link
Contributor

@mpuccio mpuccio commented Oct 5, 2020

This introduces the changes required to run the ITS tracking suite on dataset with a different number of layers (ITS3 with more than 3 layers in the IB, ALICE3...).
@mconcas please check that everything is fine with you.

@qgp FYI

bovulpes
bovulpes previously approved these changes Oct 30, 2020
Copy link
Collaborator

@bovulpes bovulpes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no MFT or common code involved.

@mpuccio
Copy link
Contributor Author

mpuccio commented Nov 26, 2020

Hi @davidrohr, @iouribelikov
this is the latest version of the tracker that is able to reconstruct tracks from the new ALICE3 geometry and also partial ITS2 geometry (the cosmics).
The GPU part of the code compiles, but it is not functional for the time being. We will put it in operation again once the strobe aware reconstruction is also implemented.
Not sure why o2 CI is failing, but the rest is green so if it is fine with you I would merge (+squash).
Cheers,
Max

Copy link
Collaborator

@davidrohr davidrohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, I have seen that the o2 CI is currently generally failing but fullCI and mac have passed, so it should be OK. If @iouribelikov approves as well, we can squash-merge it.

@mpuccio
Copy link
Contributor Author

mpuccio commented Nov 27, 2020

Thanks @iouribelikov !!

@davidrohr davidrohr merged commit 5dfcf63 into AliceO2Group:dev Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants