-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not quit on empty payload #7444
Conversation
failed tests seems to be unrelated to the commit |
@peressounko: in which case you expect no payload? Why do you return in this case w/o providing any output? This may eventually lead to the loss of the TF for the whole combined workflow. |
@shahor02 Dear Ruben, I removed exit without sending data. Now should be OK. Could you approve? |
Hi @peressounko The fullCI got stuck somewhere... Sorry for being picky, but could you please run it locally to be sure it is not related to PHOS? If everyhing is fine, I will merge it, it will appear in the next nightly. Cheers, |
@shahor02, Hi Ruben, I run test as env ALIBUILD_O2_TESTS=1 aliBuild build O2 --defaults o2 --debug. Some tests failed but they I think not related to PHOS 2021-10-30@10:58:01:DEBUG:O2:O2:0: Start 18: Framework/Utils/test/test_RootTreeReader.cxx 2021-10-30@10:59:56:DEBUG:O2:O2:0: 126/403 Test #98: Detectors/Base/test/testMatBudLUT.cxx ................................................***Failed 58.44 sec 2021-10-30@11:05:45:DEBUG:O2:O2:0: 245/403 Test #222: Detectors/TRD/base/test/testTRDDiffusionCoefficient.cxx ..............................***Failed 16.21 sec 2021-10-30@11:10:21:DEBUG:O2:O2:0: 369/403 Test #363: o2sim_hepmc ..........................................................................***Failed Required regular expression not found. Regex=[SIMULATION RETURNED SUCCESFULLY 2021-10-30@11:12:22:DEBUG:O2:O2:0: 2021-10-30@11:12:22:DEBUG:O2:O2:0: The following tests FAILED: 2021-10-30@11:13:28:DEBUG:O2:O2:0: 100% tests passed, 0 tests failed out of 93 |
Hi @peressounko Thanks, but i meant just the full system test, which failed in the CI. Ok i can run it myself in a few hours |
@peressounko ok, test passed here but I see that sometimes it is stuck due to the ITS reco in async mode, will contact @mpuccio. Merging. |
No description provided.