fixes in TOF calibration workflow #7679
Conversation
|
WIP |
noferini
force-pushed
the
dev
branch
2 times, most recently
from
005510a
to
6b12ac6
Compare
|
@shahor02 -> this is now ready for the review (many fixes in TOF calibration workflow after running several tests on Beam Test data). Two comments:
@njacazio -> once this PR will be merger you can open yours in O2Physics (adding EventTimeMaker moved from TOFReconstruction to TOFBase) |
There was a problem hiding this comment.
Hi @noferini
see one comment bellow. BTW, what about this question: #7610 (review) ?
| *(mTimeSlewing[i]) = *(source.mTimeSlewing[i]); | ||
| (*(mChannelStart[i])) = (*(source.mChannelStart[i])); | ||
| *(mFractionUnderPeak[i]) = *(source.mFractionUnderPeak[i]); | ||
| *(mSigmaPeak[i]) = *(source.mSigmaPeak[i]); |
There was a problem hiding this comment.
don't you need to copy also mGlobalOffset?
There was a problem hiding this comment.
You are right. I probably missed it when copy and paste (and workflow didn't complain also in execution).
About #7610
I implemented an autodetection for fill scheme in case it is not provided.
It will be automatically skipped once the fill scheme will be filled with the information of collision context (at the moment I didn't know how to retrieve that info from there).
No description provided.