TPC: reduce use of static keyword #8577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
static keyword has been used unnecessarily which led to construction of TPC objects at library load time (such as mapper) ... even when TPC algorithms are not run. The static keyword is not necessary here, since the mapper object is in any case a singleton.
davidrohr
approved these changes
Apr 13, 2022
wiechula
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static keyword has been used unnecessarily which led
to construction of TPC objects at library load time (such as mapper)
... even when TPC algorithms are not run.
The static keyword is not necessary here, since the mapper object
is in any case a singleton.