Reporting and protection for interleaved chip data error #8579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahor02
requested review from
iouribelikov,
bovulpes,
rpezzi and
mconcas
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes (noticed in the replay of injected MC data) the data of some chip appears interleaved with data of others (it seems it is not that the data of this chip is fragmented but some pieces of it can repeat after other chips data). As a result multiple instances of the ChipPixelData for the same chip where created, leading to race condition and eventual crash in the clusterization.
This PR detects such errors, reports them as
Chip data interleaved on the cableto infologger and produces raw data dump (if requested). The excessive chip data is discarded.