Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Partition<Filtered>, add separate sliceByCached for joins, filtered and nested filtered #8626

Merged
merged 4 commits into from
Apr 22, 2022

Conversation

saganatt
Copy link
Collaborator

Hi @ktf @aalkin

the Join method is a copy of the Table sliceByCached(), and Filtered is a copy of FilteredBase method. The problem is in returning exact O2 table type, what apparently cannot be done without copies or making sliceByCached() a standalone function and changing the UI. I need the exact type so as to use sliceByCached() for faster event mixing, which will come in another PR.

The changes in Partition constructor fix a newly discovered bug in creating Partitions on Filtered. The buggy methods were called when creating Partitions<Filtered> inside process() or calling sliceByCached() on Partitions<Filtered>.

@saganatt saganatt requested a review from a team as a code owner April 21, 2022 06:12
@ktf ktf self-requested a review April 21, 2022 08:51
Copy link
Member

@ktf ktf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it compiles.

@saganatt
Copy link
Collaborator Author

CI errors unrelated, can we merge?

@jgrosseo jgrosseo merged commit 360de51 into AliceO2Group:dev Apr 22, 2022
@saganatt saganatt deleted the slice-cached branch April 28, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants