removing kafka event in DCS plugin for EOF received from DCS #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopers8
approved these changes
Sep 23, 2024
teo
reviewed
Sep 30, 2024
Comment on lines
-1419
to
-1429
| the.EventWriterWithTopic(TOPIC).WriteEvent(&pb.Ev_IntegratedServiceEvent{ | ||
| Name: call.GetName(), | ||
| OperationName: call.Func, | ||
| OperationStatus: pb.OpStatus_ONGOING, | ||
| OperationStep: "perform DCS call: StartOfRun", | ||
| OperationStepStatus: pb.OpStatus_DONE_ERROR, | ||
| EnvironmentId: envId, | ||
| Payload: string(payloadJson[:]), | ||
| Error: logMsg, | ||
| }) | ||
|
|
There was a problem hiding this comment.
I agree with this change. Beyond the question of whether the stream io.EOF was timely or not from the DCS side, it could be argued that a stream being closed either way should not generate a Kafka event, because it concerns a technicality of DCS-ECS communication and says nothing about the actual state of the DCS.
However, the behaviour should be consistent across all DCS operations. @justonedev1 could you please make sure this change also applies to PFR and EOR?
There was a problem hiding this comment.
sure, I will do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this is described in ticket OCTRL-924