Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User details page #1020

Merged
merged 11 commits into from
Aug 16, 2024
Merged

User details page #1020

merged 11 commits into from
Aug 16, 2024

Conversation

sonwit
Copy link
Contributor

@sonwit sonwit commented Aug 15, 2024

User detiails page

Description

Create user details page

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@sonwit sonwit requested a review from allinox August 15, 2024 09:05
Copy link
Contributor

@allinox allinox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaaand we're live with the next page! Great work!! 🎉

I left a few suggestions and requests here, but none of it is really crucial or complicated, so I'll just approve this anyway so you can add them and merge this at your convenience 😊

src/features/amUI/common/PageContainer/PageContainer.tsx Outdated Show resolved Hide resolved
src/features/amUI/common/PageContainer/PageContainer.tsx Outdated Show resolved Hide resolved
src/features/amUI/userRightsPage/UserRightsPage.tsx Outdated Show resolved Hide resolved
src/features/amUI/userRightsPage/UserRightsPage.tsx Outdated Show resolved Hide resolved
src/features/amUI/users/UserItem/UserItem.module.css Outdated Show resolved Hide resolved
src/localizations/en.json Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Aug 15, 2024

@sonwit sonwit merged commit b24cacc into main Aug 16, 2024
8 checks passed
@sonwit sonwit deleted the feat/users/1008-user-details-pagr branch August 16, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants