Chore/908 move overview org to rtk query #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
kind/chore
sonwit
commented
Aug 28, 2024
.../Altinn.AccessManagement.UI/Altinn.AccessManagement.UI.Core/Services/APIDelegationService.cs
Outdated
Show resolved
Hide resolved
allinox
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Great job getting rid of the overviewOrg slice and cleaning up our code! 😄🎉
Most of my comments are semantics and nitpicks, but there is one functionality thing.
However, I trust you'll fix it without much issue so I'm gonna go ahead an approve anyway so you can merge it without being forced to go through another round of QA 😊
.../Altinn.AccessManagement.UI/Altinn.AccessManagement.UI.Core/Services/APIDelegationService.cs
Outdated
Show resolved
Hide resolved
.../Altinn.AccessManagement.UI/Altinn.AccessManagement.UI.Core/Services/APIDelegationService.cs
Outdated
Show resolved
Hide resolved
.../Altinn.AccessManagement.UI/Altinn.AccessManagement.UI.Core/Services/APIDelegationService.cs
Show resolved
Hide resolved
.../Altinn.AccessManagement.UI/Altinn.AccessManagement.UI.Core/Services/APIDelegationService.cs
Outdated
Show resolved
Hide resolved
...essManagement.UI/Altinn.AccessManagement.UI.Tests/Controllers/APIDelegationControllerTest.cs
Show resolved
Hide resolved
...I.Tests/Data/RequestInputs/MaskinportenSchema/RevokeOffered/Input_revoke_delegation_dto.json
Outdated
Show resolved
Hide resolved
…ate on new delegation
…ng expected overview organizations
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move overview org to rtk query
Description
Related Issue(s)
Verification
Documentation