Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run BFF tests on PRs #1053

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Run BFF tests on PRs #1053

merged 4 commits into from
Sep 5, 2024

Conversation

allinox
Copy link
Contributor

@allinox allinox commented Aug 29, 2024 •
edited
Loading

Description

The bff tests seems to have slipped out of our PR automatic tests by accident - adding them back in

Related Issue(s)

#1054

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added bugfix kind/bug Used when something isn't working labels Aug 29, 2024
@allinox allinox requested a review from sonwit August 30, 2024 15:35
@Altinn Altinn deleted a comment from sonarcloud bot Sep 5, 2024
sonwit
sonwit approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@sonwit sonwit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
All green tests! 💚
It will be great to have the tests run on PRs.

@allinox allinox merged commit 7711bd8 into main Sep 5, 2024
6 of 7 checks passed
@allinox allinox deleted the fix/BFF-tests-not-running-on-PRs branch September 5, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonwit sonwit sonwit approved these changes

Assignees
No one assigned
Labels
bugfix kind/bug Used when something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allinox @sonwit