Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BFF: Implement delegation endpoint #517

Merged
merged 7 commits into from
Sep 1, 2023
Merged

BFF: Implement delegation endpoint #517

merged 7 commits into from
Sep 1, 2023

Conversation

allinox
Copy link
Contributor

@allinox allinox commented Aug 31, 2023

Description

This PR implements the delegation endpoint in the BFF with a functioning mock and tests.

In addition to this, it adds a few small changes:

  • Updates ServiceResource model
  • Filters service-getters so that only resources with the flags visible and delegable are given to frontend
  • Changes the DelegationOutput model so that it actions are only given by a single string such as in checkAccess-endpoint
  • Updates dependecies Designsystem and designsystem tokens
  • A small visible fix on light colored Actionbar to display border on small size

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the kind/feature-request Used when issue is a new feature or request label Aug 31, 2023
Albertlarsen
Albertlarsen approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@Albertlarsen Albertlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff 😊

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability E 1 Vulnerability
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

72.2% 72.2% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@allinox allinox merged commit 7e27683 into main Sep 1, 2023
4 of 5 checks passed
@allinox allinox deleted the feat/single-rights/396-BFF-implement-delegation-endpoint branch September 1, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Albertlarsen Albertlarsen Albertlarsen approved these changes

Assignees
No one assigned
Labels
kind/feature-request Used when issue is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allinox @Albertlarsen