Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/single rights/503 choose rights page #518

Merged
merged 31 commits into from
Sep 6, 2023
Merged

Feat/single rights/503 choose rights page #518

merged 31 commits into from
Sep 6, 2023

Conversation

Albertlarsen
Copy link
Contributor

@Albertlarsen Albertlarsen commented Aug 31, 2023 •
edited
Loading

Description

  1. Adds a ChooseRightsPage
  2. Adds PartiallyDelegable status logic in SingleRightsSlice
  3. Adds warning color in ResourceActionBar

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the kind/feature-request Used when issue is a new feature or request label Aug 31, 2023
@Albertlarsen Albertlarsen marked this pull request as ready for review August 31, 2023 10:42
allinox
allinox requested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@allinox allinox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't hate me for this landslide of comments 🙈

src/features/singleRight/delegate/ChooseRightsPage/ChooseRightsPage.tsx Show resolved Hide resolved
src/features/singleRight/delegate/ChooseServicePage/ResourceActionBar/ResourceActionBar.tsx Show resolved Hide resolved
src/localizations/no_nb.json Outdated Show resolved Hide resolved
src/features/singleRight/delegate/ChooseRightsPage/ChooseRightsPage.tsx Outdated Show resolved Hide resolved
src/features/singleRight/delegate/ChooseRightsPage/ChooseRightsPage.tsx Outdated Show resolved Hide resolved
src/features/singleRight/delegate/ChooseServicePage/ChooseServicePage.tsx Outdated Show resolved Hide resolved
src/features/apiDelegation/components/SummaryPage/SummaryPage.tsx Show resolved Hide resolved
src/localizations/no_nb.json Outdated Show resolved Hide resolved
src/rtk/features/singleRights/singleRightsSlice.ts Outdated Show resolved Hide resolved
src/rtk/features/singleRights/singleRightsSlice.ts Outdated Show resolved Hide resolved
allinox
allinox approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@allinox allinox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Awesome work! ✨
This was a really tough task but now it looks and works great! 😄

src/features/singleRight/delegate/ChooseRightsPage/ChooseRightsPage.tsx Outdated Show resolved Hide resolved
src/features/singleRight/delegate/ChooseRightsPage/ChooseRightsPage.tsx Outdated Show resolved Hide resolved
src/features/singleRight/delegate/ChooseRightsPage/ChooseRightsPage.tsx Outdated Show resolved Hide resolved
src/localizations/en.json Outdated Show resolved Hide resolved
src/rtk/features/singleRights/singleRightsSlice.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Albertlarsen Albertlarsen merged commit a4eabeb into main Sep 6, 2023
4 of 5 checks passed
@Albertlarsen Albertlarsen deleted the feat/single-rights/503-ChooseRightsPage branch September 6, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allinox allinox Awaiting requested review from allinox

Assignees
No one assigned
Labels
kind/feature-request Used when issue is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Albertlarsen @allinox