Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/api delegation/read api id from url #673

Merged
merged 7 commits into from
Jan 2, 2024

Conversation

Albertlarsen
Copy link
Contributor

@Albertlarsen Albertlarsen commented Dec 22, 2023

Important info:
A button click will add 2 of the same APIs in the chosen list because we use React.StrictMode in development environment. However if you comment out React.StrictMode you will be able to test how it actually will be like in prod, since React.StrictMode doesn't render application 2 times in prod.

Description

Adds implementation of reading and writing api-ids to url.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the kind/feature-request Used when issue is a new feature or request label Dec 22, 2023
@Albertlarsen Albertlarsen marked this pull request as ready for review December 31, 2023 14:09
Copy link
Contributor

@allinox allinox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant work! ✨
I've tried to be thorough with my testing, and as far as I can see, it works really well 😄

@Albertlarsen Albertlarsen merged commit 8212091 into main Jan 2, 2024
1 check passed
@Albertlarsen Albertlarsen deleted the feat/api-delegation/read-api-id-from-url branch January 2, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request Used when issue is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants