Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect change in storage api to get auth info #400

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Reflect change in storage api to get auth info #400

merged 2 commits into from
Jun 28, 2023

Conversation

HenningNormann
Copy link
Contributor

Description

Reflect change in storage api to get auth info and support for user secrets the same way as in other platform components.

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Reflect change in storage api to get auth info and support for user s…
5ec889c 
…ecrets the same way as in other platform components.
@jonkjetiloye
Copy link
Member

Build issue in Test project (InstanceMetadataRepositoryMock.cs) caused by the change in the interface will need to be fixed.

@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

70.0% 70.0% Coverage
0.0% 0.0% Duplication

@HenningNormann HenningNormann merged commit 4b0d608 into main Jun 28, 2023
8 of 9 checks passed
@HenningNormann HenningNormann deleted the feature/storageapi-2 branch June 28, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonkjetiloye jonkjetiloye jonkjetiloye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HenningNormann @jonkjetiloye