Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eventlog implementation #490

Merged
merged 14 commits into from
Oct 17, 2023
Merged

Eventlog implementation #490

merged 14 commits into from
Oct 17, 2023

Conversation

acn-dgopa
Copy link
Member

@acn-dgopa acn-dgopa commented Sep 21, 2023 •
edited
Loading

Description

  • Implented eventlog for authorization call
    • Added authorization event model
    • Added events queue client to help queue the event to the queue storage
    • Added helper class to map the context request and response to the authorization event model
    • Added event log service. The controller calls the eventlog service to queue the event to the storage
    • Added some new unit tests and added assertions to existing unit tests

Related Issue(s)/PR's

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@acn-dgopa acn-dgopa linked an issue Sep 29, 2023 that may be closed by this pull request
Implement event log for authorization #461
Closed
4 tasks
@acn-dgopa acn-dgopa marked this pull request as ready for review October 6, 2023 10:10
@acn-dgopa acn-dgopa changed the title Work In Progress --- Eventlog implementation Eventlog implementation Oct 6, 2023
@acn-dgopa acn-dgopa requested a review from lovoll October 6, 2023 11:17
This was referenced Oct 6, 2023
Merged
Merged
TheTechArch
TheTechArch approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@TheTechArch TheTechArch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

jonkjetiloye
jonkjetiloye reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@jonkjetiloye jonkjetiloye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is two failing tests at the moment, and some code smells for missing documentation headers and code style which can be reviewed.
For the implementation itself, I have no further comments.

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

89.9% 89.9% Coverage
0.0% 0.0% Duplication

@acn-dgopa acn-dgopa merged commit 41f0153 into main Oct 17, 2023
8 of 9 checks passed
@acn-dgopa acn-dgopa deleted the feature/eventlog-implementation-part1 branch October 17, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonkjetiloye jonkjetiloye jonkjetiloye left review comments

@TheTechArch TheTechArch TheTechArch approved these changes

@lovoll lovoll Awaiting requested review from lovoll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement event log for authorization
3 participants
@acn-dgopa @TheTechArch @jonkjetiloye