Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/multi data model with validation #730

Open
wants to merge 69 commits into
base: main
Choose a base branch
from
Open

Feat/multi data model with validation #730

wants to merge 69 commits into from
+10,392 −4,458

Commits on Jul 9, 2024

  1. Removes form-data delete check

    @danielskovli
    danielskovli committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    cf1bbf5 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Implements AllowUserCreate and AllowUserDelete methodology. Fixes… 

    … various tests and minor issues
    @danielskovli
    danielskovli committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7798803 View commit details
    Browse the repository at this point in the history

  2. Temp project ref to Storage.Interface

    @danielskovli
    danielskovli committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ad56781 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Access testing for DataController -> Create and Delete

    @danielskovli
    danielskovli committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    5484854 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Verifies MaxCount before creating a new data element

    @danielskovli
    danielskovli committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    87cae85 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Merge branch 'main' into feature/subform

    @danielskovli
    danielskovli committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    ddc9199 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Implement support for multiple data models in expressions

    @ivarne
    ivarne committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    8d9d77d View commit details
    Browse the repository at this point in the history

  2. Restructure validation to support incremental validation for multiple… 

    … data models
    @ivarne
    ivarne committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a688536 View commit details
    Browse the repository at this point in the history

  3. Fix tests and cleanup

    @ivarne
    ivarne committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f7b91e0 View commit details
    Browse the repository at this point in the history

  4. Fix sonar cloud issues

    @ivarne
    ivarne committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e6cda48 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Add tests for shadow fields and hidden component data removal in proc… 

    …ess/next
    @ivarne
    ivarne committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    3c4ac0c View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. chore: update to new storage nuget

    @HauklandJ
    HauklandJ committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    c27f627 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Improve testing for multiple patch endpoint

    @ivarne
    ivarne committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    79a918b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into feat/multi-data-model… 

    …-with-validation
    @ivarne
    ivarne committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9007d42 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Merge branch 'main' into feat/multi-data-model-with-validation

    @ivarne
    ivarne authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    62356fb View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. update Storage.Interface package reference to 3.33.0

    @HauklandJ
    HauklandJ committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e23d1d2 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Merge remote-tracking branch 'origin/main' into feature/subform

    @danielskovli
    danielskovli committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    ac353e4 View commit details
    Browse the repository at this point in the history

  2. Fixes some tests that were double-creating the default data element

    @danielskovli
    danielskovli committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    af1200b View commit details
    Browse the repository at this point in the history

  3. Reorders DataController->MaxCount logic, adds missing ClassRef check … 

    …before CreateAppModelData call
    @danielskovli
    danielskovli committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    07c1af7 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. More changes to make tests work after merge 

    Make expression engine async
    @ivarne
    ivarne committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    300faac View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into feat/multi-data-model… 

    …-with-validation
    @ivarne
    ivarne committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    4734382 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Introduces LayoutSet.Type and adds null checks for LayoutSet.Tasks

    @danielskovli
    danielskovli committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    45d2108 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Almost make the tests pass

    @ivarne
    ivarne committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    e36b6cb View commit details
    Browse the repository at this point in the history

  2. Fix last remaining known bugs

    @ivarne
    ivarne committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    df3fa25 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into feat/multi-data-model… 

    …-with-validation
    @ivarne
    ivarne committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    552b846 View commit details
    Browse the repository at this point in the history

  4. fix async warning

    @ivarne
    ivarne committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    eaf0af8 View commit details
    Browse the repository at this point in the history

  5. Don't filter fields to remove by doing a double lookup

    @ivarne
    ivarne committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    278e170 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/feature/subform' into feat/multi… 

    …-data-model-with-validation
    @ivarne
    ivarne committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    ae2f6d9 View commit details
    Browse the repository at this point in the history

  7. Fix sonar suggestions and tests

    @ivarne
    ivarne committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    269e0a3 View commit details
    Browse the repository at this point in the history

  8. fix another warning

    @ivarne
    ivarne committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    c92d62b View commit details
    Browse the repository at this point in the history

  9. Fix another batch of sonar cloud issues

    @ivarne
    ivarne committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    46dafb4 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Implement SubFormComponent and use for validation

    @ivarne
    ivarne committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    7ea4e54 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into feat/multi-data-model… 

    …-with-validation
    @ivarne
    ivarne committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    fae563f View commit details
    Browse the repository at this point in the history

  3. Fix tests after merge with main

    @ivarne
    ivarne committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    dea4fe9 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Update storage.interfaces

    @ivarne
    ivarne committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    85fc76c View commit details
    Browse the repository at this point in the history

  2. Fix tests after storage upgrade

    @ivarne
    ivarne committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    6d3fb4e View commit details
    Browse the repository at this point in the history

  3. Add LayoutId to required validation descriptions

    @ivarne
    ivarne committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9a3a35a View commit details
    Browse the repository at this point in the history

  4. Add tests for subform validation

    @ivarne
    ivarne committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1d30664 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Add appMetadata to LayoutEvaluatorState

    @ivarne
    ivarne committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    ef8dcab View commit details
    Browse the repository at this point in the history

  2. Fix typos and make sonar more happy

    @ivarne
    ivarne committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    110b8e8 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. Revert changes to use scoped services 

    Opened #751 to consider making bigger changes for v9
    @ivarne
    ivarne committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    dfb250a View commit details
    Browse the repository at this point in the history

  2. Remove unused usings

    @ivarne
    ivarne committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    f71dad1 View commit details
    Browse the repository at this point in the history

  3. Remove implicit cast, as it was no longer used in tests (and hid bugs… 

    … in main code)
    @ivarne
    ivarne committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    4c6f4d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Remove file added by error

    @ivarne
    ivarne committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    225f934 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into feat/multi-data-model… 

    …-with-validation
    @ivarne
    ivarne committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e7f3413 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into feat/multi-data-model… 

    …-with-validation
    @ivarne
    ivarne committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    82f859c View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Add ignoredValidators as a comma separated GET parameter to /validate… 

    … endpoint
    @ivarne
    ivarne committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    cc68b17 View commit details
    Browse the repository at this point in the history

  2. Cleanup validatorService. Add new tests and telemetry

    @ivarne
    ivarne committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    259212c View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into feat/multi-data-model… 

    …-with-validation
    @ivarne
    ivarne committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    b1b9085 View commit details
    Browse the repository at this point in the history

  4. Make sonar cloud complaints editor warnings instead of suggestions 

    * Unused usings
* Mark members static

Much easier to see theese issues before sonar cloud runs
    @ivarne
    ivarne committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    1081d5f View commit details
    Browse the repository at this point in the history

  5. Activate CA1816: Call GC.SuppressFinalize correctly 

    Make it easier to get 0 sonar cloud warnings by making its issues warnings
    @ivarne
    ivarne committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    18d4169 View commit details
    Browse the repository at this point in the history

  6. Fix more sonar cloud issues

    @ivarne
    ivarne committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    93caa71 View commit details
    Browse the repository at this point in the history

  7. Make change to IProcessExclusiveGateway backwards compatible

    @ivarne
    ivarne committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    54c5ffb View commit details
    Browse the repository at this point in the history

  8. Add additional status codes to swagger

    @ivarne
    ivarne committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    450f53d View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Update Instance.Data when writing copied data without shadow fields

    @ivarne
    ivarne committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    434528b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Merge remote-tracking branch 'origin/main' into feat/multi-data-model… 

    …-with-validation
    @ivarne
    ivarne committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    32d5d15 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Add concept of nonIncrementalValidators 

    Some validators can neither run on every request for efficeincy,
nor has a sensible way to implement HasRelevantChanges.

Theese validators need to only run on process/next,
or when explicitly requested in a call to /validate

Also added NoIncrementalUpdates (with [JsonIgnore(WhenWritingDefault)]) to
ValidationIssueWithSource, so that FE can distinguish
what issues won't be fixed with incremental updates.

/validate now supports a boolean to run either only incremental, only non
incremnetal or all validators (default)
    @ivarne
    ivarne committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    71b129f View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Add ModelSerializationService and other cleanup as a prerequisite to … 

    …new dataProcessor
    @ivarne
    ivarne committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f3ebc39 View commit details
    Browse the repository at this point in the history

  2. Add draft support for adding/removing/modifying other data elements i… 

    …n dataProcessWrite
    @ivarne
    ivarne committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    fdc4cb4 View commit details
    Browse the repository at this point in the history

  3. Code review fixes

    @ivarne
    ivarne committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2e4cb52 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Various cleanup tasks 

    * Use IInstanceDataMutator for actions
* Return List instead of dictionary for models and validation issues in MultipleDataPatch for improved swagger doc
* New IDataWriteProcessor interface with IInstanceDataMutator and change list to mimik IValidator
* IValidator gets ShouldRunForTask(string taskId) so that
    * Required validators only runs for tasks with layout.
    * Expression validators only runs for tasks with datatypes that has expressions validation files
* Revert DataElementIdentifier to a simple wrapper for Guid (that caches the string version)
    @ivarne
    ivarne committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    c77239f View commit details
    Browse the repository at this point in the history

  2. Rename DataElementId to DataElementIdentifier

    @ivarne
    ivarne committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    29f2bb8 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #809 from Altinn/feat/ivarne/multiDataProcessing 

    Add IInstanceDataModifier and use it for a new dataProcessing interface and extend the UserActionContext to support modifying data elements.
    @ivarne
    ivarne authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    1f75bb8 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into feat/multi-data-model… 

    …-with-validation
    @ivarne
    ivarne committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    cc73fd4 View commit details
    Browse the repository at this point in the history

  5. Fix issues and tests failing after merge

    @ivarne
    ivarne committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2ae6862 View commit details
    Browse the repository at this point in the history

  6. Rename id=>dataElementId in api 

    also a few final touches and possible test fixes
    @ivarne
    ivarne committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    7ddd6d0 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/main' into feat/multi-data-model… 

    …-with-validation
    @ivarne
    ivarne committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    9e493c5 View commit details
    Browse the repository at this point in the history

  8. Use async versions of File access methods in DataClientMock

    @ivarne
    ivarne committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a6ca853 View commit details
    Browse the repository at this point in the history

  9. Reorganize ProcessTaskFinalizer to use CachedInstanceDataAccessor

    @ivarne
    ivarne committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    165af46 View commit details
    Browse the repository at this point in the history