Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nginx refused to boot when a hostname was invalid #102

Merged
merged 3 commits into from
May 22, 2024
Merged

Nginx refused to boot when a hostname was invalid #102

merged 3 commits into from
May 22, 2024

Conversation

martinothamar
Copy link
Contributor

@martinothamar martinothamar commented May 22, 2024 •
edited
Loading

Description

Nginx refused to boot when a hostname was invalid
Letting the upstream be a variable makes Nginx not crash on startup, and it will resolve dynamically

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@martinothamar martinothamar added the kind/bug Something isn't working label May 22, 2024
@martinothamar martinothamar self-assigned this May 22, 2024
@martinothamar martinothamar merged commit afdf641 into main May 22, 2024
@martinothamar martinothamar deleted the fix/missing-grafana-host-blocks-nginx-startup branch May 22, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HauklandJ HauklandJ HauklandJ approved these changes

Assignees

@martinothamar martinothamar

Labels
kind/bug Something isn't working
Projects
Team Apps
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinothamar @HauklandJ