Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove toLower call when adding org claim as this will fail if the username based org has uppercase characters somewhere. #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove toLower call when adding org claim as this will fail if the username based org has uppercase characters somewhere. #53

wants to merge 1 commit into from
+1 −1

Conversation

RonnyB71
Copy link
Member

Description

Fixes an issue where it's assumed that org short codes always are lowercase. This is true for production, but not localtest/development.

Related Issue(s)

  • N/A

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Remove toLower call when adding org claim as this will fail if the us…
807014d 
…ername based org has uppercase characters somewhere.
tjololo
tjololo approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@tjololo tjololo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, should we get a review from the auth team?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjololo tjololo tjololo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RonnyB71 @tjololo