Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat : Added ls() method with numbered output for files in stash directory #104

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feat : Added ls() method with numbered output for files in stash directory #104

wants to merge 1 commit into from
+25 −7

Conversation

Prakhar29Sharma
Copy link

Feat : Added ls() method with numbered output for files in stash directory

  • Have you renamed the PR Title in a meaningful way?

Related Issue

closes #99

Description

  • Implemented ls() to display files as a numbered list inside the stash directory.
  • Updated display() to call ls() when no snippet_name is passed.
  • Ensured the output format matches the requirement of numbered file listing.

Type of change

What sort of changes have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the code style of this project.
  • I have followed the contribution guidelines
  • I have performed a self-review of my own code.
  • I have ensured my changes don't generate any new warnings or errors.
  • I have updated the documentation (if necessary).
  • I have resolved all merge conflicts.

@Prakhar29Sharma
Added ls() method with numbered output for files in stash directory
ee183c2 
- Implemented ls() to display files as a numbered list inside the stash directory.
- Updated display() to call ls() when no snippet_name is passed.
- Ensured the output format matches the requirement of numbered file listing.
@Prakhar29Sharma Prakhar29Sharma linked an issue Oct 10, 2024 that may be closed by this pull request
Feature Request: Display files in stash directory #99
Open
@Wahid7852
Copy link
Collaborator

can you show me an image which verifies this PR

@Prakhar29Sharma
Copy link
Author

image

This is the output returned when I call ls() method from package/models.py

Wahid7852
Wahid7852 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@Wahid7852 Wahid7852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wahid7852 Wahid7852 Wahid7852 approved these changes

@jindalpriyanshu101 jindalpriyanshu101 Awaiting requested review from jindalpriyanshu101

@ShashwatAgrawal20 ShashwatAgrawal20 Awaiting requested review from ShashwatAgrawal20

@this-is-yaash this-is-yaash Awaiting requested review from this-is-yaash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Display files in stash directory
2 participants
@Prakhar29Sharma @Wahid7852