Fixes for nastruct, ZDNA and parallel DNA #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e same direction. If so this was a chi flip and we also need to flip X. If not that is an error bc a flip around X should not be possible.
…rs, ensure axes are properly flipped before looking at cutoffs etc
… 'guessbp'; was always a hack to make up for the bad bp detection of non wc pairs which should now be fixed.
…3' to 5'. Flipx XZ when ZDNA in base pair determination
That took a lonnnnng long time.
|
@hainm I added a new data set to |
|
Since I have people waiting on this functionality I'm going to merge, but I'll open an issue over at pytraj so as not to forget. |
yeah please open a case. Please post the error too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 6.18.0.
guessbpobsolete.bpmode.<name>[nxyz]for printing the base pair axes normal (Z) vector.