-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default PDB chain ID from blank to 'Z' #747
Conversation
… ID when null 'Z'.
…n additional output trajectory options.
… use the default chain id when writing. This makes it so that e.g. selection by chainid wont return a false positive when specifying the default chain id, printing the topology wont make it seem like the default chain ID is actually part of the topology, etc.
…o not bother with a default chain ID
@swails from Jenkins:
Are PGI compilers no longer available or is this a config change thing? |
run jenkins |
1 similar comment
run jenkins |
The problem was that the PGI installation was broken in Docker containers on the Jenkins master (it works everywhere else). The reason was a shortcut I took on that node -- I don't have enough space on my root disk to fit all of the compiler suites I want to install in But in a docker container that only mounts For the time being I just removed the PGI label from the master node so Jenkins won't try PGI builds on that node. Once I get the PGI installation fixed on that node I'll add the label back. But for now, Jenkins is green again :) |
@swails Thanks Jason! I'm going to try one more appveyor build. Right now the issue is:
In lines 82/83 I'm just using the standard POSIX redirects ( |
…indows doesnt know about /dev/stderr
User can get linux subsystem fro Microsoft store now: https://docs.microsoft.com/en-us/windows/wsl/install-win10 :)) |
@dacase Related to ParmEd/ParmEd#1055.
According to the PDB standard, the chain ID should be a "non-blank alphanumeric character". This PR makes it so that for output PDBs, if no chain ID information is present in the topology a default of 'Z' is used. Note that this does not happen when writing PQR files since those do not conform to the PDB standard anyway. The old behavior (outputting a blank character as chain ID) can be obtained via the already existing
chainid <char>
keyword for PDBtrajout
, e.g.This PR also adds a new keyword to the
mask
command,trajargs
, which allows passing a comma-separated list of trajectory arguments tomask
when writing out Mol2/PDB files (which allows recovering the old PDBs with blank chain ID for that command).Updates docs (including fixing areas where text ran off the PDB page) and adds a test.