Skip to content

Commit

Permalink
review modifications
Browse files Browse the repository at this point in the history
  • Loading branch information
AndrewEichmann-NOAA committed Sep 11, 2023
1 parent 8ffd748 commit 94b1393
Show file tree
Hide file tree
Showing 5 changed files with 40 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ source "${HOMEgfs}/ush/jjob_header.sh" -e "prepoceanobs" -c "base prepoceanobs"
##############################################
# Set variables used in the script
##############################################
# Ignore possible spelling error (nothing is misspelled)
# shellcheck disable=SC2153

##############################################
# Begin JOB SPECIFIC work
Expand All @@ -32,8 +30,9 @@ if [[ -e "${pgmout}" ]] ; then
fi

##########################################
# Do not remove the Temporary working directory (do this in POST)
# Handle the temporary working directory
##########################################
cd "${DATAROOT}" || exit 1
cd "${DATAROOT}" || (echo "FATAL ERROR: ${DATAROOT} does not exist. ABORT!"; exit 1)
[[ ${KEEPDATA} = "NO" ]] && rm -rf "${DATA}"

exit 0
19 changes: 19 additions & 0 deletions jobs/rocoto/prepoceanobs.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#! /usr/bin/env bash

export STRICT="NO"
source "${HOMEgfs}/ush/preamble.sh"

###############################################################
# Source UFSDA workflow modules
. "${HOMEgfs}/ush/load_ufsda_modules.sh"
status=$?
[[ ${status} -ne 0 ]] && exit "${status}"

export job="prepoceanobs"
export jobid="${job}.$$"

###############################################################
# Execute the JJOB
"${HOMEgfs}"/jobs/JGLOBAL_PREP_OCEAN_OBS
status=$?
exit "${status}"
10 changes: 0 additions & 10 deletions parm/config/gfs/config.ocnanalprepobs

This file was deleted.

10 changes: 10 additions & 0 deletions parm/config/gfs/config.prepoceanobs
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
#!/bin/bash

########## config.prepoceanobs ##########
# Pre Ocn Analysis specific

echo "BEGIN: config.config.prepoceanobs"

# Get task specific resources
. "${EXPDIR}/config.resources" prepoceanobs
echo "END: config.prepoceanobs"
16 changes: 8 additions & 8 deletions parm/config/gfs/config.resources
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ if [[ $# -ne 1 ]]; then
echo "waveinit waveprep wavepostsbs wavepostbndpnt wavepostbndpntbll wavepostpnt"
echo "wavegempak waveawipsbulls waveawipsgridded"
echo "postsnd awips gempak"
echo "ocnanalprep ocnanalprepobs ocnanalbmat ocnanalrun ocnanalchkpt ocnanalpost ocnanalvrfy"
echo "ocnanalprep prepoceanobs ocnanalbmat ocnanalrun ocnanalchkpt ocnanalpost ocnanalvrfy"
exit 1

fi
Expand Down Expand Up @@ -345,14 +345,14 @@ elif [[ "${step}" = "ocnanalprep" ]]; then
export npe_node_ocnanalprep
export memory_ocnanalprep="24GB"

elif [[ "${step}" = "ocnanalprepobs" ]]; then
elif [[ "${step}" = "prepoceanobs" ]]; then

export wtime_ocnanalprepobs="00:10:00"
export npe_ocnanalprepobs=1
export nth_ocnanalprepobs=1
npe_node_ocnanalprepobs=$(echo "${npe_node_max} / ${nth_ocnanalprepobs}" | bc)
export npe_node_ocnanalprepobs
export memory_ocnanalprepobs="24GB"
export wtime_prepoceanobs="00:10:00"
export npe_prepoceanobs=1
export nth_prepoceanobs=1
npe_node_prepoceanobs=$(echo "${npe_node_max} / ${nth_prepoceanobs}" | bc)
export npe_node_prepoceanobs
export memory_prepoceanobs="24GB"


elif [[ "${step}" = "ocnanalbmat" ]]; then
Expand Down

0 comments on commit 94b1393

Please sign in to comment.