add some missing asserts (#1002)

App-vNext · Jan 7, 2023 · 55aaa7c · 55aaa7c
1 parent c874285
commit 55aaa7c
Show file tree

Hide file tree

Showing 9 changed files with 46 additions and 16 deletions.
diff --git a/src/Polly.Specs/Caching/CacheAsyncSpecs.cs b/src/Polly.Specs/Caching/CacheAsyncSpecs.cs
@@ -644,6 +644,8 @@ public async Task Should_execute_oncachemiss_and_oncacheput_if_cache_does_not_ho
 
         contextPassedToOnCachePut.Should().BeSameAs(contextToExecute);
         keyPassedToOnCachePut.Should().Be(operationKey);
+        contextPassedToOnCacheMiss.Should().NotBeNull();
+        keyPassedToOnCacheMiss.Should().Be("SomeOperationKey");
     }
 
     [Fact]
@@ -675,6 +677,8 @@ public async Task Should_execute_oncachemiss_but_not_oncacheput_if_cache_does_no
 
         contextPassedToOnCachePut.Should().BeNull();
         keyPassedToOnCachePut.Should().BeNull();
+        contextPassedToOnCacheMiss.Should().BeEmpty();
+        keyPassedToOnCacheMiss.Should().Be("SomeOperationKey");
     }
 
     [Fact]

diff --git a/src/Polly.Specs/CircuitBreaker/AdvancedCircuitBreakerAsyncSpecs.cs b/src/Polly.Specs/CircuitBreaker/AdvancedCircuitBreakerAsyncSpecs.cs
@@ -2276,6 +2276,7 @@ await breaker.Awaiting(x => x.RaiseExceptionAsync<DivideByZeroException>())
         // duration has passed, circuit now half open
         breaker.CircuitState.Should().Be(CircuitState.HalfOpen);
         onHalfOpenCalled.Should().Be(1);
+        onResetCalled.Should().Be(0);
     }
 
     [Fact]

diff --git a/src/Polly.Specs/CircuitBreaker/AdvancedCircuitBreakerSpecs.cs b/src/Polly.Specs/CircuitBreaker/AdvancedCircuitBreakerSpecs.cs
@@ -2270,6 +2270,7 @@ public void Should_call_onhalfopen_when_automatically_transitioning_to_halfopen_
         // duration has passed, circuit now half open
         breaker.CircuitState.Should().Be(CircuitState.HalfOpen);
         onHalfOpenCalled.Should().Be(1);
+        onResetCalled.Should().Be(0);
     }
 
     [Fact]

diff --git a/src/Polly.Specs/CircuitBreaker/CircuitBreakerAsyncSpecs.cs b/src/Polly.Specs/CircuitBreaker/CircuitBreakerAsyncSpecs.cs
@@ -993,6 +993,7 @@ await breaker.Awaiting(x => x.RaiseExceptionAsync<DivideByZeroException>())
         // duration has passed, circuit now half open
         breaker.CircuitState.Should().Be(CircuitState.HalfOpen);
         onHalfOpenCalled.Should().Be(1);
+        onResetCalled.Should().Be(0);
     }
 
     [Fact]

diff --git a/src/Polly.Specs/CircuitBreaker/CircuitBreakerSpecs.cs b/src/Polly.Specs/CircuitBreaker/CircuitBreakerSpecs.cs
@@ -985,6 +985,7 @@ public void Should_call_onhalfopen_when_automatically_transitioning_to_halfopen_
         // duration has passed, circuit now half open
         breaker.CircuitState.Should().Be(CircuitState.HalfOpen);
         onHalfOpenCalled.Should().Be(1);
+        onResetCalled.Should().Be(0);
     }
 
     [Fact]

diff --git a/src/Polly.Specs/CircuitBreaker/CircuitBreakerTResultAsyncSpecs.cs b/src/Polly.Specs/CircuitBreaker/CircuitBreakerTResultAsyncSpecs.cs
@@ -1066,6 +1066,7 @@ await breaker.Awaiting(x => x.ExecuteAsync(() => Task.FromResult(ResultPrimitive
         // duration has passed, circuit now half open
         breaker.CircuitState.Should().Be(CircuitState.HalfOpen);
         onHalfOpenCalled.Should().Be(1);
+        onResetCalled.Should().Be(0);
     }
 
     [Fact]

diff --git a/src/Polly.Specs/CircuitBreaker/CircuitBreakerTResultSpecs.cs b/src/Polly.Specs/CircuitBreaker/CircuitBreakerTResultSpecs.cs
@@ -1057,6 +1057,7 @@ public void Should_call_onhalfopen_when_automatically_transitioning_to_halfopen_
         // duration has passed, circuit now half open
         breaker.CircuitState.Should().Be(CircuitState.HalfOpen);
         onHalfOpenCalled.Should().Be(1);
+        onResetCalled.Should().Be(0);
     }
 
     [Fact]

diff --git a/src/Polly.Specs/Registry/PolicyRegistrySpecs.cs b/src/Polly.Specs/Registry/PolicyRegistrySpecs.cs
@@ -268,39 +268,42 @@ public void Should_be_able_to_retrieve_stored_Policy_by_interface_using_Indexer(
     public void Should_not_throw_while_retrieving_when_key_does_not_exist_using_TryGet()
     {
         string key = Guid.NewGuid().ToString();
-        Policy outPolicy = null;
+        Policy policy = null;
         bool result = false;
 
-        _registry.Invoking(r => result = r.TryGet(key, out outPolicy))
+        _registry.Invoking(r => result = r.TryGet(key, out policy))
             .Should().NotThrow();
 
         result.Should().BeFalse();
+        policy.Should().BeNull();
     }
 
     [Fact]
     public void Should_not_throw_while_retrieving_when_key_does_not_exist_using_TryGetPolicyTResult()
     {
         string key = Guid.NewGuid().ToString();
-        Policy<ResultPrimitive> outPolicy = null;
+        Policy<ResultPrimitive> policy = null;
         bool result = false;
 
-        _registry.Invoking(r => result = r.TryGet(key, out outPolicy))
+        _registry.Invoking(r => result = r.TryGet(key, out policy))
             .Should().NotThrow();
 
         result.Should().BeFalse();
+        policy.Should().BeNull();
     }
 
     [Fact]
     public void Should_not_throw_while_retrieving_when_key_does_not_exist_using_TryGetPolicy_by_interface()
     {
         string key = Guid.NewGuid().ToString();
-        ISyncPolicy<ResultPrimitive> outPolicy = null;
+        ISyncPolicy<ResultPrimitive> policy = null;
         bool result = false;
 
-        _registry.Invoking(r => result = r.TryGet<ISyncPolicy<ResultPrimitive>>(key, out outPolicy))
+        _registry.Invoking(r => result = r.TryGet<ISyncPolicy<ResultPrimitive>>(key, out policy))
             .Should().NotThrow();
 
         result.Should().BeFalse();
+        policy.Should().BeNull();
     }
 
     [Fact]
@@ -310,6 +313,7 @@ public void Should_throw_while_retrieving_using_Get_when_key_does_not_exist()
         Policy policy = null;
         _registry.Invoking(r => policy = r.Get<Policy>(key))
             .Should().Throw<KeyNotFoundException>();
+        policy.Should().BeNull();
     }
 
     [Fact]
@@ -319,6 +323,7 @@ public void Should_throw_while_retrieving_using_GetTResult_when_key_does_not_exi
         Policy<ResultPrimitive> policy = null;
         _registry.Invoking(r => policy = r.Get<Policy<ResultPrimitive>>(key))
             .Should().Throw<KeyNotFoundException>();
+        policy.Should().BeNull();
     }
 
     [Fact]
@@ -328,25 +333,27 @@ public void Should_throw_while_retrieving_using_Get_by_interface_when_key_does_n
         ISyncPolicy<ResultPrimitive> policy = null;
         _registry.Invoking(r => policy = r.Get<ISyncPolicy<ResultPrimitive>>(key))
             .Should().Throw<KeyNotFoundException>();
+        policy.Should().BeNull();
     }
 
     [Fact]
     public void Should_throw_while_retrieving_when_key_does_not_exist_using_Indexer()
     {
         string key = Guid.NewGuid().ToString();
-        IsPolicy outPolicy = null;
-        _registry.Invoking(r => outPolicy = r[key])
+        IsPolicy policy = null;
+        _registry.Invoking(r => policy = r[key])
             .Should().Throw<KeyNotFoundException>();
+        policy.Should().BeNull();
     }
 
-
     [Fact]
     public void Should_throw_when_retrieving_using_Get_when_key_is_null()
     {
         string key = null;
         Policy policy = null;
         _registry.Invoking(r => policy = r.Get<Policy>(key))
             .Should().Throw<ArgumentNullException>();
+        policy.Should().BeNull();
     }
 
     [Fact]
@@ -356,6 +363,7 @@ public void Should_throw_when_retrieving_using_GetTResult_when_key_is_null()
         Policy<ResultPrimitive> policy = null;
         _registry.Invoking(r => policy = r.Get<Policy<ResultPrimitive>>(key))
             .Should().Throw<ArgumentNullException>();
+        policy.Should().BeNull();
     }
 
     [Fact]
@@ -365,6 +373,7 @@ public void Should_throw_when_retrieving_using_Get_by_interface_when_key_is_null
         ISyncPolicy<ResultPrimitive> policy = null;
         _registry.Invoking(r => policy = r.Get<ISyncPolicy<ResultPrimitive>>(key))
             .Should().Throw<ArgumentNullException>();
+        policy.Should().BeNull();
     }
 
     [Fact]
@@ -374,6 +383,7 @@ public void Should_throw_when_retrieving_using_Indexer_when_key_is_null()
         IsPolicy policy = null;
         _registry.Invoking(r => policy = r[key])
             .Should().Throw<ArgumentNullException>();
+        policy.Should().BeNull();
     }
     #endregion
 

diff --git a/src/Polly.Specs/Registry/ReadOnlyPolicyRegistrySpecs.cs b/src/Polly.Specs/Registry/ReadOnlyPolicyRegistrySpecs.cs
@@ -121,39 +121,42 @@ public void Should_be_able_to_retrieve_stored_Policy_by_interface_using_Indexer(
     public void Should_not_throw_while_retrieving_when_key_does_not_exist_using_TryGet()
     {
         string key = Guid.NewGuid().ToString();
-        Policy outPolicy = null;
+        Policy policy = null;
         bool result = false;
 
-        ReadOnlyRegistry.Invoking(r => result = r.TryGet(key, out outPolicy))
+        ReadOnlyRegistry.Invoking(r => result = r.TryGet(key, out policy))
             .Should().NotThrow();
 
         result.Should().BeFalse();
+        policy.Should().BeNull();
     }
 
     [Fact]
     public void Should_not_throw_while_retrieving_when_key_does_not_exist_using_TryGetPolicyTResult()
     {
         string key = Guid.NewGuid().ToString();
-        Policy<ResultPrimitive> outPolicy = null;
+        Policy<ResultPrimitive> policy = null;
         bool result = false;
 
-        ReadOnlyRegistry.Invoking(r => result = r.TryGet(key, out outPolicy))
+        ReadOnlyRegistry.Invoking(r => result = r.TryGet(key, out policy))
             .Should().NotThrow();
 
         result.Should().BeFalse();
+        policy.Should().BeNull();
     }
 
     [Fact]
     public void Should_not_throw_while_retrieving_when_key_does_not_exist_using_TryGetPolicy_by_interface()
     {
         string key = Guid.NewGuid().ToString();
-        ISyncPolicy<ResultPrimitive> outPolicy = null;
+        ISyncPolicy<ResultPrimitive> policy = null;
         bool result = false;
 
-        ReadOnlyRegistry.Invoking(r => result = r.TryGet<ISyncPolicy<ResultPrimitive>>(key, out outPolicy))
+        ReadOnlyRegistry.Invoking(r => result = r.TryGet<ISyncPolicy<ResultPrimitive>>(key, out policy))
             .Should().NotThrow();
 
         result.Should().BeFalse();
+        policy.Should().BeNull();
     }
 
     [Fact]
@@ -163,6 +166,7 @@ public void Should_throw_while_retrieving_using_Get_when_key_does_not_exist()
         Policy policy = null;
         ReadOnlyRegistry.Invoking(r => policy = r.Get<Policy>(key))
             .Should().Throw<KeyNotFoundException>();
+        policy.Should().BeNull();
     }
 
     [Fact]
@@ -172,6 +176,7 @@ public void Should_throw_while_retrieving_using_GetTResult_when_key_does_not_exi
         Policy<ResultPrimitive> policy = null;
         ReadOnlyRegistry.Invoking(r => policy = r.Get<Policy<ResultPrimitive>>(key))
             .Should().Throw<KeyNotFoundException>();
+        policy.Should().BeNull();
     }
 
     [Fact]
@@ -181,6 +186,7 @@ public void Should_throw_while_retrieving_using_Get_by_interface_when_key_does_n
         ISyncPolicy<ResultPrimitive> policy = null;
         ReadOnlyRegistry.Invoking(r => policy = r.Get<ISyncPolicy<ResultPrimitive>>(key))
             .Should().Throw<KeyNotFoundException>();
+        policy.Should().BeNull();
     }
 
     [Fact]
@@ -190,16 +196,17 @@ public void Should_throw_while_retrieving_when_key_does_not_exist_using_Indexer(
         IsPolicy outPolicy = null;
         ReadOnlyRegistry.Invoking(r => outPolicy = r[key])
             .Should().Throw<KeyNotFoundException>();
+        outPolicy.Should().BeNull();
     }
 
-
     [Fact]
     public void Should_throw_when_retrieving_using_Get_when_key_is_null()
     {
         string key = null;
         Policy policy = null;
         ReadOnlyRegistry.Invoking(r => policy = r.Get<Policy>(key))
             .Should().Throw<ArgumentNullException>();
+        policy.Should().BeNull();
     }
 
     [Fact]
@@ -209,6 +216,7 @@ public void Should_throw_when_retrieving_using_GetTResult_when_key_is_null()
         Policy<ResultPrimitive> policy = null;
         ReadOnlyRegistry.Invoking(r => policy = r.Get<Policy<ResultPrimitive>>(key))
             .Should().Throw<ArgumentNullException>();
+        policy.Should().BeNull();
     }
 
     [Fact]
@@ -218,6 +226,7 @@ public void Should_throw_when_retrieving_using_Get_by_interface_when_key_is_null
         ISyncPolicy<ResultPrimitive> policy = null;
         ReadOnlyRegistry.Invoking(r => policy = r.Get<ISyncPolicy<ResultPrimitive>>(key))
             .Should().Throw<ArgumentNullException>();
+        policy.Should().BeNull();
     }
 
     [Fact]
@@ -227,6 +236,7 @@ public void Should_throw_when_retrieving_using_Indexer_when_key_is_null()
         IsPolicy policy = null;
         ReadOnlyRegistry.Invoking(r => policy = r[key])
             .Should().Throw<ArgumentNullException>();
+        policy.Should().BeNull();
     }
     #endregion