Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README.md for Polly.Core #1060

Merged
merged 3 commits into from
Mar 18, 2023
Merged

Add README.md for Polly.Core #1060

merged 3 commits into from
Mar 18, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Mar 17, 2023

The issue or feature being addressed

Here we are just adding README.md for Polly.Core project that adds technical details for contributors. This file is just transferred from v8-poc branch and updated with the latest API.

Details on the issue fix or feature implementation

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor grammar suggestions.

src/Polly.Core/README.md Outdated Show resolved Hide resolved
}
```

The `ResilienceStrategy` unifies the 4 different policies used now in Polly. User actions are executed under a single API. The are many methods
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have more than four in total. Maybe just say "many" or "various"?

src/Polly.Core/README.md Outdated Show resolved Hide resolved
src/Polly.Core/README.md Outdated Show resolved Hide resolved
src/Polly.Core/README.md Outdated Show resolved Hide resolved
src/Polly.Core/README.md Outdated Show resolved Hide resolved
src/Polly.Core/README.md Outdated Show resolved Hide resolved
src/Polly.Core/README.md Outdated Show resolved Hide resolved
src/Polly.Core/README.md Outdated Show resolved Hide resolved
src/Polly.Core/README.md Outdated Show resolved Hide resolved
context.IsSynchronous = true;
context.IsVoid = true;
context.ResultType = typeof(VoidResult);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a follow-up PR, I wonder if we should integrate something like MarkdownSnippets.Tool into the repo and have real working/compilable samples in the test project that can auto-generate so these things are easy to keep up-to-date and working as v8 gets implemented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice and it would help to keep the docs in sync with the code. Love the idea.

Fyi, we are also using docfx that supports the similar thing such as referencing snippets from the code using regions:
https://dotnet.github.io/docfx/docs/markdown.html?tabs=linux%2Cdotnet#code-snippet

I'll go ahead and merge this and we address this in follow-up.

@martintmk martintmk merged commit f314ce3 into main Mar 18, 2023
@martincostello martincostello deleted the mtomka/polly.core-readme branch March 18, 2023 10:58
@martincostello martincostello added this to the v8.0.0 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants