Add more benchmarks for V8 #1106
Conversation
| |---------------------- |---------:|--------:|--------:|------:|--------:|-------:|----------:|------------:| | ||
| | ExecuteRateLimiter_V7 | 173.8 ns | 2.33 ns | 3.48 ns | 1.00 | 0.00 | 0.0448 | 376 B | 1.00 | | ||
| | ExecuteRateLimiter_V8 | 207.9 ns | 2.06 ns | 2.89 ns | 1.19 | 0.03 | 0.0229 | 192 B | 0.51 | |
There was a problem hiding this comment.
Interesting that this one is slower.
There was a problem hiding this comment.
Yup surprised me too. It also allocates on every call (around 40 bytes, the remaining 152 bytes will be addressed by pooling the ResilienceContext).
Might be something that could be addressed with .NET folks.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1106 +/- ##
=======================================
Coverage 77.69% 77.69%
=======================================
Files 199 199
Lines 4748 4748
Branches 846 846
=======================================
Hits 3689 3689
Misses 854 854
Partials 205 205
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Details on the issue fix or feature implementation
This PR adds more benchmark for V8 resilience strategies.
Confirm the following