Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not record null tags to meter #1438

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Do not record null tags to meter #1438

merged 1 commit into from
Jul 27, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jul 27, 2023

Details on the issue fix or feature implementation

This improves performance a bit.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jul 27, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #1438 (ada70e2) into main (7dc06c0) will increase coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1438      +/-   ##
==========================================
+ Coverage   83.92%   83.94%   +0.02%     
==========================================
  Files         276      276              
  Lines        6524     6533       +9     
  Branches     1006     1013       +7     
==========================================
+ Hits         5475     5484       +9     
  Misses        840      840              
  Partials      209      209              
Flag Coverage Δ
linux 83.94% <100.00%> (+0.02%) ⬆️
macos 83.94% <100.00%> (+0.02%) ⬆️
windows 83.94% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...s/Telemetry/ResilienceTelemetryDiagnosticSource.cs 100.00% <100.00%> (ø)
...xtensions/Telemetry/TelemetryResilienceStrategy.cs 100.00% <100.00%> (ø)

@martintmk martintmk enabled auto-merge (squash) July 27, 2023 07:02
@martintmk martintmk merged commit b825c91 into main Jul 27, 2023
12 checks passed
@martintmk martintmk deleted the mtomka/ignore-null-tags branch July 27, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants