Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debugging experience for ResilienceProperties #1524

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 29, 2023

Details on the issue fix or feature implementation

Noticed while playing with the API. These changes make it more friendly to debug and view what's inside ResilienceProperties.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 29, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 29, 2023
@martintmk martintmk enabled auto-merge (squash) August 29, 2023 10:44
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1524 (9db08b1) into main (dd511b2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1524   +/-   ##
=======================================
  Coverage   84.00%   84.00%           
=======================================
  Files         278      278           
  Lines        6540     6540           
  Branches     1023     1023           
=======================================
  Hits         5494     5494           
  Misses        837      837           
  Partials      209      209           
Flag Coverage Δ
macos 84.00% <ø> (?)
windows 84.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Polly.Core/ResilienceProperties.cs 100.00% <ø> (ø)

@martintmk martintmk merged commit 160b9ef into main Aug 29, 2023
12 checks passed
@martintmk martintmk deleted the mtomka/resilience-properties-debugging branch August 29, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants