Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not encourage returning the same instance from chaos strategies #1899

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jan 15, 2024

Details on the issue fix or feature implementation

These overloads could lead to the same problems as in #1877. For results, returning the same cached value (i.e. HttpResponseMessage can also cause issues.

Better not to encourage this in our APIs.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added this to the v8.3.0 milestone Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd1b310) 84.68% compared to head (8bfecf2) 84.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1899      +/-   ##
==========================================
- Coverage   84.68%   84.66%   -0.03%     
==========================================
  Files         309      309              
  Lines        6845     6833      -12     
  Branches     1052     1052              
==========================================
- Hits         5797     5785      -12     
  Misses        839      839              
  Partials      209      209              
Flag Coverage Δ
linux 84.66% <100.00%> (-0.03%) ⬇️
macos ?
windows 84.66% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk martintmk merged commit 0d78805 into main Jan 15, 2024
17 checks passed
@martintmk martintmk deleted the mtomka/drop-some-simmy-apis branch January 15, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants