Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got rid of IDE0066, IDE0250, IDE0063 warnings #1930

Conversation

baranyaimate
Copy link
Contributor

The issue or feature being addressed

Contributes to #1290

Details on the issue fix or feature implementation

Got rid of IDE0066, IDE0250, IDE0063 warnings in the Polly project

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martincostello martincostello enabled auto-merge (squash) January 26, 2024 16:22
auto-merge was automatically disabled January 26, 2024 16:30

Head branch was pushed to by a user without write access

@martincostello martincostello enabled auto-merge (squash) January 26, 2024 16:35
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb63dab) 84.79% compared to head (fec589e) 84.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1930      +/-   ##
==========================================
+ Coverage   84.79%   84.81%   +0.01%     
==========================================
  Files         312      312              
  Lines        6893     6901       +8     
  Branches     1056     1056              
==========================================
+ Hits         5845     5853       +8     
  Misses        839      839              
  Partials      209      209              
Flag Coverage Δ
linux 84.81% <100.00%> (+0.01%) ⬆️
macos 84.81% <100.00%> (+0.01%) ⬆️
windows 84.81% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 7c8a6fc into App-vNext:main Jan 26, 2024
14 checks passed
@baranyaimate baranyaimate deleted the Cleanup-1290-IDE0066-IDE0250-IDE-0063 branch January 26, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants