Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add cheat sheet for outcome chaos strategy #1984

Merged

Conversation

peter-csala
Copy link
Contributor

@peter-csala peter-csala commented Feb 22, 2024

Pull Request

The issue or feature being addressed

Details on the issue fix or feature implementation

Screenshot 2024-03-08 at 15 10 16

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.64%. Comparing base (3e2164e) to head (e1a15c5).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1984      +/-   ##
==========================================
- Coverage   83.64%   83.64%   -0.01%     
==========================================
  Files         312      312              
  Lines        7106     7105       -1     
  Branches     1056     1054       -2     
==========================================
- Hits         5944     5943       -1     
  Misses        789      789              
  Partials      373      373              
Flag Coverage Δ
linux ?
macos 83.64% <ø> (-0.01%) ⬇️
windows 83.64% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peter-csala peter-csala marked this pull request as ready for review March 8, 2024 14:11
@peter-csala
Copy link
Contributor Author

@martincostello I've updated the samples to use the current API. I've also respected the anti-pattern regarding mixture of result and exception usage. Could you please check it again?

@martincostello martincostello merged commit 68a3c7f into App-vNext:main Mar 8, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants