Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DiagnosticSource reference from Extensions for NET 6.0 and later #2033

Merged

Conversation

lahma
Copy link
Contributor

@lahma lahma commented Mar 27, 2024

Pull Request

The issue or feature being addressed

Just a small trimming to dependencies as NET6+ does not need explicit reference to System.Diagnostics.DiagnosticSource

Details on the issue fix or feature implementation

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.67%. Comparing base (785c482) to head (fc1f143).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2033      +/-   ##
==========================================
- Coverage   83.70%   83.67%   -0.03%     
==========================================
  Files         312      312              
  Lines        7105     7105              
  Branches     1054     1054              
==========================================
- Hits         5947     5945       -2     
- Misses        788      789       +1     
- Partials      370      371       +1     
Flag Coverage Δ
linux 83.67% <ø> (-0.03%) ⬇️
macos 83.67% <ø> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello added this to the v8.3.2 milestone Mar 27, 2024
@martincostello martincostello added CI/build dependencies Pull requests that update a dependency file labels Mar 27, 2024
@martincostello martincostello merged commit c1a97cb into App-vNext:main Mar 27, 2024
16 of 17 checks passed
@lahma lahma deleted the trim-diagnostics-source-reference branch March 29, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/build dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants