Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning CA1062#AsyncFallbackPolicy #2233

Conversation

Zombach
Copy link
Contributor

@Zombach Zombach commented Jul 22, 2024

Pull Request

The issue or feature being addressed

#2215

Details on the issue fix or feature implementation

  • Suppress CA1062 in src/Polly/Fallback/AsyncFallbackPolicy.cs or fix the warning

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.00%. Comparing base (72331dc) to head (fa3da38).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2233   +/-   ##
=======================================
  Coverage   84.00%   84.00%           
=======================================
  Files         313      313           
  Lines        7227     7229    +2     
  Branches     1078     1079    +1     
=======================================
+ Hits         6071     6073    +2     
  Misses        785      785           
  Partials      371      371           
Flag Coverage Δ
linux 84.00% <100.00%> (+<0.01%) ⬆️
macos 84.00% <100.00%> (+<0.01%) ⬆️
windows 84.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 5686e37 into App-vNext:main Jul 23, 2024
18 checks passed
@Zombach Zombach deleted the zombach/remove-warning-ca1062#async-fallback-policy branch July 23, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants