Put dotnet_diagnostic.CA1852.severity = warning into effect. Fix the resulting warnings

[Henr1k80]

Pull Request

The issue or feature being addressed

Performance

Details on the issue fix or feature implementation

InternalsVisibleTo disables CA1852, so it is not in effect.
dotnet/roslyn-analyzers#6438

I have set this to ignore InternalsVisibleTo:
dotnet_code_quality.CA1852.ignore_internalsvisibleto = true

I have fixed the resulting warnings

I have locally set this to ignore InternalsVisibleTo:
dotnet_code_quality.CA1852.ignore_internalsvisibleto = true

Let me know if I should commit that change as well.
Then the snippet project also need some changes to obey CA1852.

Confirm the following

• I started this PR by branching from the head of the default branch
• I have targeted the PR to merge into the default branch
• I have included unit tests for the issue/feature
• I have successfully run a local build

[Henr1k80]

@dotnet-policy-service agree

[martincostello]

Let me know if I should commit that change as well.

Yes please!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.33%. Comparing base (957444f) to head (b627992).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2289      +/-   ##
==========================================
- Coverage   85.35%   85.33%   -0.03%     
==========================================
  Files         313      313              
  Lines        7444     7444              
  Branches     1122     1122              
==========================================
- Hits         6354     6352       -2     
- Misses        745      746       +1     
- Partials      345      346       +1     

Flag	Coverage Δ
linux	85.33% <100.00%> (-0.03%)	⬇️
macos	85.33% <100.00%> (-0.03%)	⬇️
windows	85.33% <100.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.