Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade sign tool #2305

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Downgrade sign tool #2305

merged 1 commit into from
Sep 26, 2024

Conversation

martincostello
Copy link
Member

@martincostello martincostello commented Sep 26, 2024

Downgrade the sign tool to the same version used when we published v8.4.1 to see if it's the source of the failure.

Downgrade the `sign` tool to the same version used when we published v8.4.1 to see if it's the source of the failure.
@martincostello martincostello added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code labels Sep 26, 2024
@martincostello martincostello added this to the v8.4.2 milestone Sep 26, 2024
@martincostello martincostello enabled auto-merge (rebase) September 26, 2024 14:59
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (f7dc35f) to head (f4abd47).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2305   +/-   ##
=======================================
  Coverage   85.39%   85.39%           
=======================================
  Files         313      313           
  Lines        7461     7461           
  Branches     1126     1126           
=======================================
  Hits         6371     6371           
  Misses        745      745           
  Partials      345      345           
Flag Coverage Δ
linux 85.39% <ø> (ø)
macos 85.39% <ø> (ø)
windows 85.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 077cf38 into main Sep 26, 2024
18 checks passed
@martincostello martincostello deleted the downgrade-sign branch September 26, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant