Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added expression bodied members, null-ref checks (bulkhead policy) #568

Merged
merged 3 commits into from
Jan 26, 2019

Conversation

moerwald
Copy link
Contributor

@moerwald moerwald commented Jan 25, 2019

The issue or feature being addressed

557, #557

Details on the issue fix or feature implementation

/src/Polly.Shared/Bulkhead/BulkheadPolicy.cs

  • Added null checks
  • Added readonly
  • Refactored to expression bodied members

Rest of the files:

  • Refactored to expression bodied members

Confirm the following

  • I started this PR by branching from the head of the latest dev vX.Y branch, or I have rebased on the latest dev vX.Y branch, or I have merged the latest changes from the dev vX.Y branch
  • I have targeted the PR to merge into the latest dev vX.Y branch as the base branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@reisenberger
Copy link
Member

Thanks @moerwald ! Looks good! I'm pushing a credit to you in the readme for all these clean-ups! (hope that's ok 🙂 )

@reisenberger reisenberger changed the title Added expression bodied members. BulkheadPolicy.cs: Added null-ref checks Added expression bodied members, null-ref checks (bulkhead policy) Jan 26, 2019
@reisenberger reisenberger added this to the v7.0.0 milestone Jan 26, 2019
@reisenberger reisenberger merged commit 2f1aabf into App-vNext:v700 Jan 26, 2019
@moerwald moerwald deleted the issue_557_Bulkhead branch February 3, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants