Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export GStreamer variables #979

Merged
merged 1 commit into from
Jul 7, 2019
Merged

Export GStreamer variables #979

merged 1 commit into from
Jul 7, 2019

Conversation

@TheAssassin
Copy link
Member

How/why will this be useful to anyone? Shouldn't we try to get rid of AppRun.c since it has some annoyances like chdir()ing around?

In any case it looks good but have you test-run it? I have no time right now, someone should try though to make sure there's no segfaults or anything.

@probonopd
Copy link
Member Author

Yes, we don't want to use it if we don't have to. But I don't know how to tell Gstreamer to look for privately bundled plugins without using environment variables. Do you?

@TheAssassin
Copy link
Member

TheAssassin commented Jul 7, 2019

linuxdeploy is going to solve this problem soon-ish.

Not saying we can't merge this. The opposite is true. If you can guarantee AppRun is running and doesn't break, sure, let's do. Just wanted to mention it's probably not going to reach anyone really.

@probonopd
Copy link
Member Author

linuxdeploy and linuxdeployqt are (currently) not using AppRun.c at all, I know.

@probonopd probonopd merged commit fef038a into master Jul 7, 2019
@probonopd probonopd deleted the gstreamer branch July 7, 2019 12:05
@TheAssassin
Copy link
Member

TheAssassin commented Jul 7, 2019

Have you tried this at least before merging? Does the build product even run? Or did you just merge and hope for the best?

@probonopd
Copy link
Member Author

Merge and hope for the best. Will revert in the second it creates problems.

@TheAssassin
Copy link
Member

I guess just downloading it and running will make sure it'll work.

@TheAssassin
Copy link
Member

Seems to work.

@vadi2
Copy link

vadi2 commented Jul 24, 2019

How can one make use of this to get GStreamer plugins loaded with linuxdeployqt? Using linuxdeployqt de6d873 (commit 6e359c5), build 689 built on 2019-05-10 17:10:54 UTC, they still aren't (log).

@probonopd
Copy link
Member Author

probonopd commented Jul 25, 2019

linuxdeployqt does not make use of this yet. One would have to deploy all needed GStreamer plugins manually (using executable=...) and use an AppRun that would set the GStreamer environment variables.

@vadi2
Copy link

vadi2 commented Jul 25, 2019

That makes sense, thanks for explaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants