Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Waterfox Alpha #1704

Closed
wants to merge 1 commit into from
Closed

Conversation

hawkeye116477
Copy link
Contributor

@hawkeye116477 hawkeye116477 commented Aug 7, 2019

New icon and slightly changed appearance. Unfortunately it still crashes with firejail.
I wanted to also add appdata.xml, but that looks like impossible on OBS, cuz it must validate URL addressees and OBS doesn't allow it to use Internet.

@probonopd
Copy link
Member

The screenshot is:

screenshot

Why is it crashing? It is running offline in Firejail, yes, but it should at least not crash?

@hawkeye116477
Copy link
Contributor Author

@probonopd It's only crashing with AppImage+Firejail, with AppImage without Firejail no crash. If I unpack AppImage, then if I use it with or without Firejail, then it's fine.

Why is it crashing? It is running offline in Firejail, yes, but it should at least not crash?
I don't know, that's probably question for Waterfox/Firejail creator.

@probonopd
Copy link
Member

Do you think I should merge this anyway? Is there a screenshot in the AppStream metainfo?

@hawkeye116477
Copy link
Contributor Author

@probonopd Is there a screenshot in the AppStream metainfo?
That was the plan to put screenshot in AppStream metainfo, but OBS doesn't allow me to add metainfo.
Do you think I should merge this anyway?
Yes, better this than nothing 😄

@probonopd
Copy link
Member

OBS doesn't allow me to add metainfo.

I doubt that. You need to upload it to OBS rather than use wget to pull it at build time.

@hawkeye116477
Copy link
Contributor Author

hawkeye116477 commented Aug 7, 2019

@probonopd Yes, I know, I uploaded, but as I previously wrote, it begins verification of URL (homepage/screenshot) and can't verify (no Internet access), also additionally I got similar problems as in AppImage/AppImageKit#603 (comment).

@probonopd
Copy link
Member

Ah, I begin to understand, it looks like one needs to pass in -n, --no-appstream Do not check AppStream metadata to linuxdeployqt so that it skips those checks.

@probonopd
Copy link
Member

Did that work for you @hawkeye116477?

@hawkeye116477
Copy link
Contributor Author

hawkeye116477 commented Aug 11, 2019

@probonopd I'm not using linuxdeployqt, all packaging is automatically done on OBS. I tried to add that, but that's not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants