-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libthai in excludelist causes problems #538
Comments
While this is my own. I wanted to add another example where it breaks an appimage. But it looks like it is on it's way in. 👍 |
So we would need a way to determine, at runtime, which one is newer; the one on the system or the one in the AppImage. |
sorry, but why? How is libthai different from any other package on the excludelist? In other words, why does this problem not exist for others? |
Good question. |
is this something that is done already? that you just have an array of and we can just append another package in? Or should this be done with a custom handler just for libthai? |
I don't remember that anyone has done that yet, but maybe @TheAssassin or @azubieta have a solution for that. (Please note that pkg2appimage is only a last resort solution; it's better to ask the application author to provide an officially made, tested, and supported AppImage.) |
I'm one of the app authors, but the ones providing the solution to packing the appimage is the framework we using which is Tauri. (You can see the issue from Tauri that references it in tauri-apps/tauri#4930) |
Hi @probonopd, I had somethingo done for libc (glibc) abd libc++ but not for libthai, it would require a special launcher that compares the library versions and pics the correct one. |
I guess people who need this need to handle this in their deployment specifically. https://github.com/darealshinji/linuxdeploy-plugin-checkrt for instance allows bundling a libstdc++ implementing a version check to load it only when needed. This really sounds like there is a need for a linuxdeploy-plugin-libthai. It can't be fixed here. |
..or a modified ld-linux loader that compares the versions inside and outside the bundle for all libraries... |
Sounds like a recipe for disaster... |
...indeed. Scary! |
Is that confirmed? I don't see any references in this issue. As far as I can see it, it shouldn't matter, really. Edit: the only comment that ever mentioned problems is #538 (comment), but there is no reference to some concrete issue or a minimal example to reproduce... |
Lines 123 to 126 in 48a9bbf
|
That just means we have to bundle both libpango and libthai, doesn't it? |
I am tryting the AppImage of gitbutler and run into the same issue. Did you find some recipe to work-around this? |
One way would be to use a tool that can bundle everything, like go-appimage |
Hey, I went back and tried to find the original issue due to which it has been put on the excludelist, but could only find the similar issue cjcliffe/CubicSDR#655. As @TheAssassin said, it seems like the issue is that when However, since then, libpango has been removed again from the excludelist in 2022. This means that the original reason why Therefore, I think this can finally be resolved by just removing I tried to use |
libthai.so.0 has been removed from the excludelist. The original reason why libthai has been added to it is an issue that occurs when libpango is not bundled but libthai is (see AppImageCommunity#538). But since then, libpango has been removed from the excludelist in 2022. This means that the original reason why libthai has been excluded is no longer relevant. Therefore it could be removed from the excludelist. This fixes AppImageCommunity#544. Additionally, the excludelist formatting has been improved. There had been different places scattered across the excludelist in which libraries have been excluded or not excluded due to other libraries (like libthai / libpango). They have all been brought together (with all information and reasoning) in one block to prevent issues like this in the future. Additionally, missing information out of AppImageCommunity#528 has been added to this block.
libthai.so.0 has been removed from the excludelist. The original reason why libthai had been added to it is an issue that occurs when libpango is not bundled but libthai is (see AppImageCommunity#538). But since then, libpango had been removed from the excludelist in 2022. This means that the original reason why libthai had been excluded is no longer relevant. Therefore it could be removed from the excludelist. This fixes AppImageCommunity#544. Additionally, the excludelist formatting has been improved. There had been different places scattered across the excludelist in which libraries had been excluded or not excluded due to other libraries (like libthai / libpango). They have all been brought together (with all information and reasoning) in one block to prevent issues like this in the future. Additionally, missing information out of AppImageCommunity#528 has been added to this block.
libthai.so.0 has been removed from the excludelist. The original reason why libthai had been added to it is an issue that occurs when libpango is not bundled but libthai is (see AppImageCommunity#538). But since then, libpango had been removed from the excludelist in 2022. This means that the original reason why libthai had been excluded is no longer relevant. Therefore it could be removed from the excludelist. This fixes AppImageCommunity#538. Additionally, the excludelist formatting has been improved. There had been different places scattered across the excludelist in which libraries had been excluded or not excluded due to other libraries (like libthai / libpango). They have all been brought together (with all information and reasoning) in one block to prevent issues like this in the future. Additionally, missing information out of AppImageCommunity#528 has been added to this block.
pkg2appimage/excludelist
Line 119 in c302f81
This breaks several appimages by assuming a Thai language library will be present on any host system. Known to be missing on several installs of Arch, Debian, Gentoo, Nix, and Slackware. A small sampling of references:
tauri-apps/tauri#4930
pineappleEA/pineapple-src#85
xournalpp/xournalpp#4660
cjcliffe/CubicSDR#852
https://discourse.appimage.org/t/how-do-distros-add-support-for-running-appimages/1648/8
The text was updated successfully, but these errors were encountered: