non-numeric values detection for highlight/story

AppleGamer22 · Dec 1, 2020 · 905f34f · 905f34f
1 parent 35236c0
commit 905f34f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/commands/highlight.ts b/src/commands/highlight.ts
@@ -58,6 +58,10 @@ export default class Highlight extends Command {
  * @returns URL string array
  */
 export async function detectFiles(browser: Browser, page: Page, highlight: string, item: number): Promise<ScrapePayload | undefined> {
+	if (isNaN(item)) {
+		await browser.close();
+		alert(`item provided is not a number: ${item}`, "danger");
+	}
 	try {
 		await page.goto(`https://www.instagram.com/stories/highlights/${highlight}`, {waitUntil: "domcontentloaded"});
 		await page.waitForSelector("body", {visible: true});

diff --git a/src/commands/story.ts b/src/commands/story.ts
@@ -45,7 +45,9 @@ export default class Story extends Command {
 					}
 					await browser.close();
 				} else return alert("Please provide a POST argument!", "danger");
-			} catch (error) { alert(error.message, "danger"); }
+			} catch (error) {
+				alert(error.message, "danger");
+			}
 		}
 	}
 }
@@ -58,6 +60,10 @@ export default class Story extends Command {
  * @returns URL string array
  */
 export async function detectFiles(browser: Browser, page: Page, user: string, item: number): Promise<ScrapePayload | undefined> {
+	if (isNaN(item)) {
+		await browser.close();
+		alert(`item provided is not a number: ${item}`, "danger");
+	}
 	try {
 		await page.goto(`https://www.instagram.com/${user}`);
 		await page.goto(`https://www.instagram.com/stories/${user}`, {waitUntil: "domcontentloaded"});
@@ -87,5 +93,7 @@ export async function detectFiles(browser: Browser, page: Page, user: string, it
 		const videoURL = (await page.$$eval("div.qbCDp > video > source", sources => sources.map(source => source.getAttribute("src"))))[0];
 		if (videoURL) urls.push(videoURL);
 		return { username, urls };
-	} catch (error) { alert(error.message, "danger"); }
+	} catch (error) {
+		alert(error.message, "danger");
+	}
 }