Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_HAL_ESP32: Add GPIO driver for ESP32 #28268

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

sblaksono
Copy link
Contributor

Add GPIO driver for ESP32

Copy link
Collaborator

@davidbuzz davidbuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs squash into a single commit, but the code changes look good

@tpwrules
Copy link
Contributor

tpwrules commented Oct 1, 2024

This looks reasonable, but please rebase on master and retest. We did just merge a big upgrade to ESP-IDF 5.3 which might break it.

@sblaksono
Copy link
Contributor Author

Done merging, tested on my esp32 board. No issue...

@tpwrules
Copy link
Contributor

tpwrules commented Oct 1, 2024

Please rebase on master and squash to one commit, the project does not permit merge commits.

@sblaksono
Copy link
Contributor Author

@tpwrules done

@peterbarker
Copy link
Contributor

@tpwrules done

Well... what @tpwrules really meant was two commits - one per logical subsystem. Sorry, we're not making this stuff up, it's in here: https://ardupilot.org/dev/docs/submitting-patches-back-to-master.html#preparing-commits :-)

I've made that split for you and tweaked a commit message and marked this one as "merge on CI pass".

Thanks!

@sblaksono
Copy link
Contributor Author

Thank you, newbie here :)

Copy link
Contributor

@tpwrules tpwrules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and "sounds" good to me :)

Sorry I did not notice the additional subsystem change.

@tpwrules tpwrules merged commit efe0037 into ArduPilot:master Oct 2, 2024
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants